Skip to content

feat(server-nestjs): align plugin services with autoSync and suspende…#2298

Open
shikanime wants to merge 3 commits into
mainfrom
shikanime/push-plkxvsyoplqv
Open

feat(server-nestjs): align plugin services with autoSync and suspende…#2298
shikanime wants to merge 3 commits into
mainfrom
shikanime/push-plkxvsyoplqv

Conversation

@shikanime

@shikanime shikanime commented Jul 8, 2026

Copy link
Copy Markdown
Member

Issues liées

#2315
#2314

Quel est le comportement actuel ?

Avant cette PR, la synchronisation des projets par les plugins (ArgoCD, GitLab, Vault, Keycloak, Nexus, SonarQube, Harbor) était soit globale, soit déclenchée uniquement par les modifications apportées dans la Console. Les projets ne disposaient d'aucune option permettant de contrôler finement la synchronisation projet par projet.

Quel est le nouveau comportement ?

Cette PR introduit les options autoSync (désactivée par défaut) et suspended (activée par défaut) au niveau projet pour l'ensemble des 7 plugins. Elle réactive les tâches planifiées horaires (@Cron(CronExpression.EVERY_HOUR)) qui ne ciblent désormais que les projets autoSync=enabled ET suspended!=enabled via la méthode getAutoSyncProjects().

Comportement de synchronisation :

  • syncProject() vérifie désormais isSuspended() et ignore le projet si vrai (avec journalisation d'avertissement).
  • Les tâches planifiées utilisent getAutoSyncProjects() à la place de getAllProjects().

Nouveaux utilitaires :

  • isSuspended(project) — indique si le projet a l'option suspended activée.
  • isAutoSync(project) — indique si le projet a l'option autoSync activée.

Couche données :

  • getAutoSyncProjects() — filtre les projets avec autoSync=enabled ET suspended!=enabled.

Configuration des plugins :

  • Centralisation des clés de configuration dans des constantes *_PLUGIN_KEY (PLUGIN_NAME, AUTO_SYNC_PLUGIN_KEY, SUSPENDED_PLUGIN_KEY) pour les 7 plugins.
  • Ajout des interrupteurs suspended et autoSync au niveau projet pour ArgoCD, GitLab, Vault, Keycloak, Nexus, SonarQube et Harbor.

@shikanime shikanime added this to the 9.20.0 milestone Jul 8, 2026
@shikanime shikanime requested a review from KepoParis July 8, 2026 09:41
@shikanime shikanime self-assigned this Jul 8, 2026
@shikanime shikanime added enhancement New feature or request tech Technical issue labels Jul 8, 2026
@github-actions github-actions Bot added the built label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime closed this Jul 8, 2026
@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 28c085b to e635708 Compare July 8, 2026 09:53
@shikanime shikanime reopened this Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch 2 times, most recently from c862f6e to 560cac3 Compare July 8, 2026 10:15
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 560cac3 to 1923518 Compare July 8, 2026 11:14
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 1923518 to f8e527d Compare July 8, 2026 12:37
Comment thread apps/server-nestjs/src/modules/gitlab/gitlab-datastore.spec.ts Fixed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from f8e527d to f18eb6a Compare July 8, 2026 13:00
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch 2 times, most recently from 6f5697d to 9583d0e Compare July 8, 2026 13:20
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch 2 times, most recently from be6563a to 89f46f6 Compare July 8, 2026 13:23
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 89f46f6 to 3bfc5fb Compare July 8, 2026 13:27
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime requested a review from KepoParis July 13, 2026 15:02
@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 14f577f to ef54811 Compare July 13, 2026 15:03
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from ef54811 to 64f35b1 Compare July 15, 2026 08:36
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 64f35b1 to 43cee42 Compare July 15, 2026 08:46
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 43cee42 to 7f1834a Compare July 15, 2026 08:51
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

4 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

5 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@cloud-pi-native-sonarqube

Copy link
Copy Markdown

…odule imports

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: Ib0cb9dd4c83a5e8e2127eb7bd0f432926a6a6964
Comment thread apps/server-nestjs/src/modules/registry/registry.service.spec.ts Fixed
Comment thread apps/server-nestjs/test/registry.e2e-spec.ts Fixed
Comment thread apps/server-nestjs/test/registry.e2e-spec.ts Fixed
Comment thread apps/server-nestjs/test/registry.e2e-spec.ts Fixed
Comment thread apps/server-nestjs/test/registry.e2e-spec.ts Fixed
Comment thread apps/server-nestjs/test/registry.e2e-spec.ts Fixed
Comment thread apps/server-nestjs/test/registry.e2e-spec.ts Fixed
… datastore tighter select

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: Ie226a611990a4b13a64c5863c5cd90f66a6a6964
Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: I603bc405c005d1eaa9da67de8a74356b6a6a6964
Comment on lines +12 to +18
plugins: {
select: {
pluginName: true,
key: true,
value: true,
},
},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben oui, c'est bizarre ça 🤔

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À revoir quand l'autre MR sur le module Infra aura été fusionnée

Comment on lines +12 to +18
plugins: {
select: {
pluginName: true,
key: true,
value: true,
},
},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben oui, c'est bizarre ça 🤔

Comment thread AGENTS.md
- Template env files use `-example` suffix (not `.example`)
- `ci/scripts/init-env.sh` copies `*-example` to active equivalents (non-destructive)

## graphify

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Hein ? Ça sort d'où ça ? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built enhancement New feature or request preview Deploy preview app with Argo-cd tech Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants